From c4390742b335a8de9ab57860d15890a411b7b712 Mon Sep 17 00:00:00 2001
From: Arthur Lefebvre <artlef@protonmail.com>
Date: Wed, 18 Mar 2026 15:18:27 +0100
Subject: [PATCH] error check: refactor code to remove warning

---
 internal/myvalidator/myvalidator.go | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/internal/myvalidator/myvalidator.go b/internal/myvalidator/myvalidator.go
index 2b02ff0..ed4de29 100644
--- a/internal/myvalidator/myvalidator.go
+++ b/internal/myvalidator/myvalidator.go
@@ -41,15 +41,18 @@ func ValidateId(db *gorm.DB, id uint, value any) error {
 }
 
 func ReturnErrorsAsJsonResponse(ac *appcontext.AppContext, err error) {
-	var httpError HttpError
-	var ve validator.ValidationErrors
-	if errors.As(err, &ve) {
+
+	ve, isValidationErrors := errors.AsType[validator.ValidationErrors](err)
+	if isValidationErrors {
 		ac.C.JSON(http.StatusBadRequest, getValidationErrors(ac, &ve))
-	} else if errors.As(err, &httpError) {
-		ac.C.JSON(httpError.StatusCode, gin.H{"error": httpError.Err.Error()})
-	} else {
-		ac.C.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+		return
 	}
+	httpError, isHttpError := errors.AsType[HttpError](err)
+	if isHttpError {
+		ac.C.JSON(httpError.StatusCode, gin.H{"error": httpError.Err.Error()})
+		return
+	}
+	ac.C.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
 }
 
 func (h HttpError) Error() string {