Add pagination for booksearch

This commit is contained in:
2025-11-11 00:32:00 +01:00
parent 87f6daef18
commit 6b2038aeec
10 changed files with 185 additions and 50 deletions

View File

@@ -1,5 +1,6 @@
<script setup> <script setup>
import { computed } from 'vue'
import { ref, computed } from 'vue'
import { getBook, getImagePathOrDefault, putReadBook, putWantReadBook, putRateBook } from './api.js' import { getBook, getImagePathOrDefault, putReadBook, putWantReadBook, putRateBook } from './api.js'
import { onBeforeRouteUpdate } from 'vue-router' import { onBeforeRouteUpdate } from 'vue-router'
import { VRating } from 'vuetify/components/VRating'; import { VRating } from 'vuetify/components/VRating';
@@ -9,12 +10,12 @@
id: String id: String
}); });
let { data, error } = getBook(props.id); let data = ref(null);
let error = ref(null);
getBook(data, error, props.id);
const imagePathOrDefault = computed(() => getImagePathOrDefault(data.value.coverPath)); const imagePathOrDefault = computed(() => getImagePathOrDefault(data.value.coverPath));
onBeforeRouteUpdate(async (to, from) => { onBeforeRouteUpdate(async (to, from) => {
let res = getBook(to.params.id); getBook(data, error, to.params.id);
data = res.data;
error = res.error;
}) })
function onRatingUpdate(rating) { function onRatingUpdate(rating) {

View File

@@ -18,23 +18,20 @@ const offset = computed(() => (pageNumber.value - 1) * limit);
let currentFilterState = ref(FilterStates.READ); let currentFilterState = ref(FilterStates.READ);
let data; let data = ref(null);
let error; let error = ref(null);
let totalBooksData; let totalBooksData = ref(null);
let errorFetchTotal; let errorFetchTotal = ref(null);
let totalBooksNumber = computed(() => totalBooksData ? totalBooksData.value["count"] : 0); let totalBooksNumber = computed(() => (typeof(totalBooksData) != 'undefined' &&
totalBooksData.value != null) ? totalBooksData.value["count"] : 0);
let pageTotal = computed(() => Math.ceil(totalBooksNumber.value / limit)) let pageTotal = computed(() => Math.ceil(totalBooksNumber.value / limit))
fetchData(); fetchData();
function fetchData() { function fetchData() {
let res = getMyBooks(currentFilterState.value, limit, offset.value); let res = getMyBooks(data, error, currentFilterState.value, limit, offset.value);
data = res.data; let resCount = getCountMyBooks(totalBooksData, errorFetchTotal, currentFilterState.value);
error = res.error;
let resCount = getCountMyBooks(currentFilterState.value);
totalBooksData = resCount.data;
} }
function onFilterButtonClick(newstate) { function onFilterButtonClick(newstate) {
@@ -48,7 +45,7 @@ function computeDynamicClass(state) {
function pageChange(newPageNumber) { function pageChange(newPageNumber) {
pageNumber.value = newPageNumber; pageNumber.value = newPageNumber;
data.value = null data.value = null;
fetchData(); fetchData();
} }

View File

@@ -9,7 +9,7 @@
if (typeof searchterm.value === "undefined" || searchterm.value === "") { if (typeof searchterm.value === "undefined" || searchterm.value === "") {
return return
} }
router.push('/search/' + searchterm.value); router.push('/search/' + encodeURIComponent(searchterm.value));
} }
</script> </script>

View File

@@ -48,7 +48,7 @@
</script> </script>
<template> <template>
<nav class="pagination" role="navigation" aria-label="pagination"> <nav v-if="props.pageTotal > 1" class="pagination" role="navigation" aria-label="pagination">
<a href="#" v-if="props.pageNumber > 1" <a href="#" v-if="props.pageNumber > 1"
@click="$emit('pageChange', Math.max(1, props.pageNumber - 1))" @click="$emit('pageChange', Math.max(1, props.pageNumber - 1))"
class="pagination-previous"> class="pagination-previous">

View File

@@ -1,27 +1,62 @@
<script setup> <script setup>
import { ref, computed } from 'vue'
import BookListElement from './BookListElement.vue'; import BookListElement from './BookListElement.vue';
import { getSearchBooks } from './api.js' import { getSearchBooks, getCountSearchBooks } from './api.js'
import { onBeforeRouteUpdate } from 'vue-router' import { onBeforeRouteUpdate } from 'vue-router'
import Pagination from './Pagination.vue'
const limit = 5;
const pageNumber = ref(1);
const offset = computed(() => (pageNumber.value - 1) * limit);
const props = defineProps({ const props = defineProps({
searchterm: String searchterm: String
}); });
let { data, error } = getSearchBooks(props.searchterm); let data = ref(null);
let error = ref(null);
let totalBooksData = ref(null);
let errorFetchTotal = ref(null);
const pageTotal = computed(() => {
let countValue = totalBooksData.value !== null ? totalBooksData.value['count'] : 0;
return Math.ceil(countValue / limit);
});
fetchData(props.searchterm);
function fetchData(searchTerm) {
getSearchBooks(data, error, searchTerm, limit, offset.value);
getCountSearchBooks(totalBooksData, errorFetchTotal, searchTerm);
}
onBeforeRouteUpdate(async (to, from) => { onBeforeRouteUpdate(async (to, from) => {
let res = getSearchBooks(to.params.searchterm); pageNumber.value = 1;
data = res.data; fetchData(to.params.searchterm);
error = res.error;
}) })
function pageChange(newPageNumber) {
pageNumber.value = newPageNumber;
data.value = null;
fetchData(props.searchterm);
}
</script> </script>
<template> <template>
<div class="booksearch"> <div class="booksearch">
<div v-if="error">{{$t('searchbook.error', {error: error.message})}}</div> <div v-if="error">{{$t('searchbook.error', {error: error.message})}}</div>
<div class="booksearchlist" v-else-if="data && data.length > 0" v-for="book in data" :key="book.id"> <div v-else-if="data && data.length > 0">
<BookListElement v-bind="book" /> <div class="booksearchlist" v-for="book in data" :key="book.id">
<BookListElement v-bind="book" />
</div>
<Pagination
:pageNumber="pageNumber"
:pageTotal="pageTotal"
maxItemDisplayed="11"
@pageChange="pageChange"/>
</div> </div>
<div v-else-if="data === null">{{$t('searchbook.loading')}}</div> <div v-else-if="data === null">{{$t('searchbook.loading')}}</div>
<div v-else>{{$t('searchbook.noresult')}}</div> <div v-else>{{$t('searchbook.noresult')}}</div>

View File

@@ -1,4 +1,3 @@
import { ref } from 'vue'
import { useAuthStore } from './auth.store.js' import { useAuthStore } from './auth.store.js'
const baseUrl = "http://localhost:8080" const baseUrl = "http://localhost:8080"
@@ -8,10 +7,7 @@ export function getImagePathOrDefault(path) {
"../defaultbook.png" : baseUrl + path; "../defaultbook.png" : baseUrl + path;
} }
function useFetch(url) { function useFetch(data, error, url) {
const data = ref(null);
const error = ref(null);
const { user } = useAuthStore(); const { user } = useAuthStore();
if (user != null) { if (user != null) {
@@ -25,25 +21,28 @@ function useFetch(url) {
.then((json) => (data.value = json)) .then((json) => (data.value = json))
.catch((err) => (error.value = err)); .catch((err) => (error.value = err));
} }
return { data, error }
} }
export function getCountMyBooks(arg) { export function getCountMyBooks(data, error, arg) {
return useFetch(baseUrl + '/mybooks/' + arg + "/count"); return useFetch(data, error, baseUrl + '/mybooks/' + arg + "/count");
} }
export function getMyBooks(arg, limit, offset) { export function getMyBooks(data, error, arg, limit, offset) {
const queryParams = new URLSearchParams({limit: limit, offset: offset}); const queryParams = new URLSearchParams({limit: limit, offset: offset});
return useFetch(baseUrl + '/mybooks/' + arg + "?" + queryParams.toString()); return useFetch(data, error, baseUrl + '/mybooks/' + arg + "?" + queryParams.toString());
} }
export function getSearchBooks(searchterm) { export function getCountSearchBooks(data, error, searchterm) {
return useFetch(baseUrl + '/search/' + searchterm); return useFetch(data, error,baseUrl + '/search/' + encodeURIComponent(searchterm) + '/count')
} }
export function getBook(id) { export function getSearchBooks(data, error, searchterm, limit, offset) {
return useFetch(baseUrl + '/book/' + id); const queryParams = new URLSearchParams({limit: limit, offset: offset});
return useFetch(data, error, baseUrl + '/search/' + encodeURIComponent(searchterm) + "?" + queryParams.toString());
}
export function getBook(data, error, id) {
return useFetch(data, error, baseUrl + '/book/' + id);
} }
export function postBook(book) { export function postBook(book) {

View File

@@ -6,6 +6,7 @@ import (
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"net/url"
"testing" "testing"
"git.artlef.fr/PersonalLibraryManager/internal/testutils" "git.artlef.fr/PersonalLibraryManager/internal/testutils"
@@ -19,33 +20,96 @@ type bookSearchGet struct {
} }
func TestSearchBook_MultipleBooks(t *testing.T) { func TestSearchBook_MultipleBooks(t *testing.T) {
books := testSearchBook(t, "san") books := testSearchBook(t, "san", "", "")
assert.Equal(t, 2, len(books)) assert.Equal(t, 2, len(books))
} }
func TestSearchBook_AllFields(t *testing.T) { func TestSearchBook_AllFields(t *testing.T) {
books := testSearchBook(t, "de san") books := testSearchBook(t, "de san", "", "")
assert.Equal(t, 1, len(books)) assert.Equal(t, 1, len(books))
assert.Equal(t, assert.Equal(t,
[]bookSearchGet{{Title: "De sang-froid", Author: "Truman Capote", Id: 18}}, []bookSearchGet{{Title: "De sang-froid", Author: "Truman Capote", Id: 18}},
books) books)
} }
func testSearchBook(t *testing.T, searchterm string) []bookSearchGet { func TestSearchBook_Limit(t *testing.T) {
books := testSearchBook(t, "a", "10", "")
assert.Equal(t, 10, len(books))
}
func TestSearchBook_Offset(t *testing.T) {
books := testSearchBook(t, "sa", "", "2")
assert.Equal(t, 3, len(books))
}
func testSearchBook(t *testing.T, searchterm string, limit string, offset string) []bookSearchGet {
router := testutils.TestSetup() router := testutils.TestSetup()
u, err := url.Parse("/search/" + searchterm)
if err != nil {
t.Error(err)
}
if limit != "" {
q := u.Query()
q.Set("limit", limit)
u.RawQuery = q.Encode()
}
if offset != "" {
q := u.Query()
q.Set("offset", offset)
u.RawQuery = q.Encode()
}
token := testutils.ConnectDemoUser(router) token := testutils.ConnectDemoUser(router)
req, _ := http.NewRequest("GET", "/search/"+searchterm, nil) req, _ := http.NewRequest("GET", u.String(), nil)
req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", token)) req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", token))
w := httptest.NewRecorder() w := httptest.NewRecorder()
router.ServeHTTP(w, req) router.ServeHTTP(w, req)
var books []bookSearchGet var books []bookSearchGet
err := json.Unmarshal(w.Body.Bytes(), &books) err = json.Unmarshal(w.Body.Bytes(), &books)
if err != nil { if err != nil {
t.Error(err) t.Error(err)
} }
assert.Equal(t, 200, w.Code) assert.Equal(t, 200, w.Code)
return books return books
} }
func TestSearchBookCount_OK(t *testing.T) {
router := testutils.TestSetup()
token := testutils.ConnectDemoUser(router)
req, _ := http.NewRequest("GET", "/search/sa/count", nil)
req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", token))
w := httptest.NewRecorder()
router.ServeHTTP(w, req)
var count countResponse
assert.Equal(t, 200, w.Code)
err := json.Unmarshal(w.Body.Bytes(), &count)
if err != nil {
t.Error(err)
}
assert.Equal(t, 5, count.Count)
}
func TestSearchBookCount_Zero(t *testing.T) {
router := testutils.TestSetup()
token := testutils.ConnectDemoUser(router)
req, _ := http.NewRequest("GET", "/search/dsfsfdsdfsfd/count", nil)
req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", token))
w := httptest.NewRecorder()
router.ServeHTTP(w, req)
var count countResponse
assert.Equal(t, 200, w.Code)
err := json.Unmarshal(w.Body.Bytes(), &count)
if err != nil {
t.Error(err)
}
assert.Equal(t, 0, count.Count)
}

View File

@@ -36,14 +36,28 @@ type BookSearchGet struct {
CoverPath string `json:"coverPath"` CoverPath string `json:"coverPath"`
} }
func FetchBookSearchGet(db *gorm.DB, searchterm string) ([]BookSearchGet, error) { func FetchBookSearchGet(db *gorm.DB, searchterm string, limit int, offset int) ([]BookSearchGet, error) {
var books []BookSearchGet var books []BookSearchGet
query := fetchBookSearchQuery(db, searchterm)
query = query.Limit(limit)
query = query.Offset(offset)
res := query.Find(&books)
return books, res.Error
}
func FetchBookSearchGetCount(db *gorm.DB, searchterm string) (int64, error) {
query := fetchBookSearchQuery(db, searchterm)
var count int64
res := query.Count(&count)
return count, res.Error
}
func fetchBookSearchQuery(db *gorm.DB, searchterm string) *gorm.DB {
query := db.Model(&model.Book{}) query := db.Model(&model.Book{})
query = query.Select("books.title, books.author, books.id," + selectStaticFilesPath()) query = query.Select("books.title, books.author, books.id," + selectStaticFilesPath())
query = query.Joins("left join static_files on (static_files.id = books.cover_id)") query = query.Joins("left join static_files on (static_files.id = books.cover_id)")
query = query.Where("LOWER(title) LIKE ?", "%"+strings.ToLower(searchterm)+"%") query = query.Where("LOWER(title) LIKE ?", "%"+strings.ToLower(searchterm)+"%")
res := query.Find(&books) return query
return books, res.Error
} }
type BookUserGet struct { type BookUserGet struct {

View File

@@ -6,14 +6,36 @@ import (
"git.artlef.fr/PersonalLibraryManager/internal/appcontext" "git.artlef.fr/PersonalLibraryManager/internal/appcontext"
"git.artlef.fr/PersonalLibraryManager/internal/myvalidator" "git.artlef.fr/PersonalLibraryManager/internal/myvalidator"
"git.artlef.fr/PersonalLibraryManager/internal/query" "git.artlef.fr/PersonalLibraryManager/internal/query"
"github.com/gin-gonic/gin"
) )
func GetSearchBooksHandler(ac appcontext.AppContext) { func GetSearchBooksHandler(ac appcontext.AppContext) {
searchterm := ac.C.Param("searchterm") searchterm := ac.C.Param("searchterm")
books, err := query.FetchBookSearchGet(ac.Db, searchterm)
limit, err := ac.GetQueryLimit()
if err != nil {
myvalidator.ReturnErrorsAsJsonResponse(&ac, err)
return
}
offset, err := ac.GetQueryOffset()
if err != nil {
myvalidator.ReturnErrorsAsJsonResponse(&ac, err)
return
}
books, err := query.FetchBookSearchGet(ac.Db, searchterm, limit, offset)
if err != nil { if err != nil {
myvalidator.ReturnErrorsAsJsonResponse(&ac, err) myvalidator.ReturnErrorsAsJsonResponse(&ac, err)
return return
} }
ac.C.JSON(http.StatusOK, books) ac.C.JSON(http.StatusOK, books)
} }
func GetSearchBooksCountHandler(ac appcontext.AppContext) {
searchterm := ac.C.Param("searchterm")
count, err := query.FetchBookSearchGetCount(ac.Db, searchterm)
if err != nil {
myvalidator.ReturnErrorsAsJsonResponse(&ac, err)
return
}
ac.C.JSON(http.StatusOK, gin.H{"count": count})
}

View File

@@ -39,6 +39,9 @@ func Setup(config *config.Config) *gin.Engine {
r.GET("/search/:searchterm", func(c *gin.Context) { r.GET("/search/:searchterm", func(c *gin.Context) {
routes.GetSearchBooksHandler(appcontext.AppContext{C: c, Db: db, I18n: bundle, Config: config}) routes.GetSearchBooksHandler(appcontext.AppContext{C: c, Db: db, I18n: bundle, Config: config})
}) })
r.GET("/search/:searchterm/count", func(c *gin.Context) {
routes.GetSearchBooksCountHandler(appcontext.AppContext{C: c, Db: db, I18n: bundle, Config: config})
})
r.GET("/book/:id", func(c *gin.Context) { r.GET("/book/:id", func(c *gin.Context) {
routes.GetBookHandler(appcontext.AppContext{C: c, Db: db, I18n: bundle, Config: config}) routes.GetBookHandler(appcontext.AppContext{C: c, Db: db, I18n: bundle, Config: config})
}) })