From 4f1452e0d9a9c01e3aa508cf6f871fcb3e7db4be Mon Sep 17 00:00:00 2001
From: Arthur Lefebvre <artlef@protonmail.com>
Date: Thu, 9 Oct 2025 00:34:57 +0200
Subject: [PATCH] fix extract error from api call

---
 front/src/AddBook.vue | 18 +++---------------
 front/src/LogIn.vue   |  6 +++---
 front/src/SignUp.vue  |  6 +++---
 front/src/api.js      |  6 +++---
 4 files changed, 12 insertions(+), 24 deletions(-)

diff --git a/front/src/AddBook.vue b/front/src/AddBook.vue
index 17fea5b..9f1a225 100644
--- a/front/src/AddBook.vue
+++ b/front/src/AddBook.vue
@@ -1,6 +1,6 @@
 <script setup>
   import { ref, reactive, computed } from 'vue'
-  import { postBook } from './api.js'
+  import { postBook, extractFormErrorFromField } from './api.js'
   import { useRouter, useRoute } from 'vue-router'
 
   const router = useRouter();
@@ -11,24 +11,12 @@
   });
   const errors = ref(null)
   const titleError = computed(() => {
-    return extractErrorFromField("Title");
+    return extractFormErrorFromField("Title", errors.value);
   })
   const authorError = computed(() => {
-    return extractErrorFromField("Author");
+    return extractFormErrorFromField("Author", errors.value);
   })
 
-  function extractErrorFromField(fieldName) {
-    if (errors.value === null) {
-     return "";
-    }
-    const titleErr = errors.value.find((e) => e["field"] === fieldName);
-    if (typeof titleErr !== 'undefined') {
-      return titleErr.error
-    } else {
-      return "";
-    }
-  }
-
   function onSubmit(e) {
     postBook(book)
       .then((res) => {
diff --git a/front/src/LogIn.vue b/front/src/LogIn.vue
index a2f2bd9..37e08fe 100644
--- a/front/src/LogIn.vue
+++ b/front/src/LogIn.vue
@@ -1,6 +1,6 @@
 <script setup>
   import { ref, computed } from 'vue'
-  import { postLogin, extractFromErrorFromField, extractGlobalFormError } from './api.js'
+  import { postLogin, extractFormErrorFromField, extractGlobalFormError } from './api.js'
   import { useRouter } from 'vue-router'
   import { useAuthStore } from './auth.store.js'
 
@@ -17,10 +17,10 @@
     return extractGlobalFormError(errors.value);
   })
   const userError = computed(() => {
-    return extractFromErrorFromField("Username", errors.value);
+    return extractFormErrorFromField("Username", errors.value);
   })
   const passwordError = computed(() => {
-    return extractFromErrorFromField("Password", errors.value);
+    return extractFormErrorFromField("Password", errors.value);
   })
 
   async function onSubmit(e) {
diff --git a/front/src/SignUp.vue b/front/src/SignUp.vue
index 4e38a4e..e7434f7 100644
--- a/front/src/SignUp.vue
+++ b/front/src/SignUp.vue
@@ -1,6 +1,6 @@
 <script setup>
   import { ref, computed } from 'vue'
-  import { postSignUp, extractFromErrorFromField, extractGlobalFormError } from './api.js'
+  import { postSignUp, extractFormErrorFromField, extractGlobalFormError } from './api.js'
   import { useRouter } from 'vue-router'
 
   const router = useRouter();
@@ -16,10 +16,10 @@
     return extractGlobalFormError(errors.value);
   })
   const userError = computed(() => {
-    return extractFromErrorFromField("Username", errors.value);
+    return extractFormErrorFromField("Username", errors.value);
   })
   const passwordError = computed(() => {
-    return extractFromErrorFromField("Password", errors.value);
+    return extractFormErrorFromField("Password", errors.value);
   })
 
   function onSubmit() {
diff --git a/front/src/api.js b/front/src/api.js
index c2958b1..7b0d44b 100644
--- a/front/src/api.js
+++ b/front/src/api.js
@@ -68,11 +68,11 @@ export function genericPostCall(apiRoute, object) {
   }
 }
 
-export function extractFromErrorFromField(fieldName, errors) {
-  if (errors === null || !('field' in errors)) {
+export function extractFormErrorFromField(fieldName, errors) {
+  if (errors === null) {
     return "";
   }
-  const titleErr = errs.find((e) => e["field"] === fieldName);
+  const titleErr = errors.find((e) => e["field"] === fieldName);
   if (typeof titleErr !== 'undefined') {
     return titleErr.error;
   } else {